Thread (15 messages) flat view 15 messages, 5 authors, 2021-08-02

RE: (subset) [PATCH v2 0/8] Add RZ/G2L Sound support

From: Biju Das <biju.das.jz@bp.renesas.com>
Date: 2021-07-31 06:42:29
Also in: alsa-devel, linux-renesas-soc

Hi Mark and Prabhakar,

+ Vinod.

The first binding patch is for SSI support in interrupt mode. so it is ok.

The second binding patch is for adding DMA support in ssi.
The example value in #dma-cells need to be updated. Earlier it was just MID/RID value.

Based on recent discussion with Vinod and Geert, It needs to updated with encoded values of 
MID/RID value and legacy channel configuration parameters, as passing the later to driver
using slave_config is not recommended.

So either drop the second patch or Will send a follow up patch fixing the example

+            dmas = <&dmac 0x2655>,
+                   <&dmac 0x2656>;

Please let me know.

Regards,
Biju
-----Original Message-----
From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Sent: 30 July 2021 20:13
To: Mark Brown <broonie@kernel.org>; Takashi Iwai <tiwai@suse.com>; Liam
Girdwood [off-list ref]; Rob Herring [off-list ref]; Jaroslav
Kysela [off-list ref]; Philipp Zabel [off-list ref]; Biju Das
[off-list ref]
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>; Chris Brandt
[off-list ref]; Chris Paterson [off-list ref];
Geert Uytterhoeven [off-list ref]; alsa-devel@alsa-project.org;
linux-renesas-soc@vger.kernel.org; Biju Das [off-list ref];
devicetree@vger.kernel.org
Subject: RE: (subset) [PATCH v2 0/8] Add RZ/G2L Sound support

Hi Mark,
quoted
-----Original Message-----
From: Mark Brown <broonie@kernel.org>
Sent: 30 July 2021 20:04
To: Takashi Iwai <tiwai@suse.com>; Liam Girdwood
[off-list ref]; Rob Herring [off-list ref]; Jaroslav
Kysela [off-list ref]; Philipp Zabel [off-list ref]; Biju
Das [off-list ref]
Cc: Mark Brown <broonie@kernel.org>; Prabhakar Mahadev Lad
[off-list ref];
Kuninori Morimoto [off-list ref]; Chris Brandt
[off-list ref]; Chris Paterson
[off-list ref]; Geert Uytterhoeven
[off-list ref]; alsa-devel@alsa- project.org;
linux-renesas-soc@vger.kernel.org; Biju Das [off-list ref];
devicetree@vger.kernel.org
Subject: Re: (subset) [PATCH v2 0/8] Add RZ/G2L Sound support

On Mon, 19 Jul 2021 14:40:32 +0100, Biju Das wrote:
quoted
This patch series aims to add ASoC support on RZ/G2L SoC's.

It is based on the work done by Chris Brandt for RZ/A ASoC driver.

Biju Das (8):
  ASoC: dt-bindings: Document RZ/G2L bindings
  sound: soc: sh: Add RZ/G2L SSIF-2 driver
  arm64: dts: renesas: r9a07g044: Add external audio clock nodes
  arm64: dts: renesas: r9a07g044: Add SSI support
  arm64: defconfig: Enable ASoC sound support for RZ/G2L SoC
  ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support
  sound: sh: rz-ssi: Add SSI DMAC support
  arm64: dts: renesas: r9a07g044: Add SSI DMA support

[...]
Applied to


https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
kernel.org%2Fpub%2Fscm%2Flinux%2
Fkernel%2Fgit%2Fbroonie%2Fsound.git&amp;data=04%7C01%7Cprabhakar.mahad
ev-
lad.rj%40bp.renesas.com%7C60c047db42e149eacdb808d9538ccc7e%7C53d82571d
a1947e49cb4625a166a4a2a%7C0%7C0%
7C637632686468564246%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI
joiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
CI6Mn0%3D%7C1000&amp;sdata=Rdyi2vXY9i%2Fly%2FOTWVFmc8k0rVbpM75FthJn7ri
jxwU%3D&amp;reserved=0 for-next

Thanks!

[1/8] ASoC: dt-bindings: Document RZ/G2L bindings
      commit: 2b761f476f3a6e0a212c8c88e7855f66edb177e0
[6/8] ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support
      commit: 5df6dfbb6de815ba3a75c788a916865212fd5221
There is a updated version of the patch [1] which was posted yesterday due
to change in handling DMA slave channel configuration [2]. Both the queued
patches need to dropped.

[1] https://patchwork.kernel.org/project/linux-renesas-
soc/patch/20210729172311.31111-2-biju.das.jz@bp.renesas.com/
[2] https://patchwork.kernel.org/project/linux-renesas-
soc/patch/20210729082520.26186-2-biju.das.jz@bp.renesas.com/

Cheers,
Prabhakar
quoted
All being well this means that it will be integrated into the
linux-next tree (usually sometime in the next 24 hours) and sent to
Linus during the next merge window (or sooner if it is a bug fix),
however if problems are discovered then the patch may be dropped or
reverted.
quoted
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems
and send followup patches addressing any issues that are reported if
needed.
quoted
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
quoted
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
quoted
Thanks,
Mark
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help