RE: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay

Hi Geert,

Thanks for the feedback.

Subject: Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay

Hi Biju,

On Wed, Jul 21, 2021 at 8:06 PM Biju Das [off-list ref]
wrote:

quoted

Hihope boards use Realtek PHY. From the very beginning it use only tx
delays. However the phy driver commit bbc4d71d63549bcd003
("net: phy: realtek: fix rtl8211e rx/tx delay config") introduced NFS
mount failure. Now it needs rx delay inaddition to tx delay for NFS
mount to work. This patch fixes NFS mount failure issue by adding MAC
internal rx delay.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue
in renesas-devel for v5.15.

Do you want a Fixes: tag?

It is a tricky situation. The phy patch is introduced in 5.9 and is backported to 5.8. 
But we don't have MaC internal delays on those kernels. So Fixes for 5.10+ will be ok I guess,
So that at least this fix will land on cip 5.10 kernel.

Regards,
Biju

quoted

--- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi

@@ -20,6 +20,7 @@
        pinctrl-names = "default";
        phy-handle = <&phy0>;
        tx-internal-delay-ps = <2000>;
+       rx-internal-delay-ps = <1800>;
        status = "okay";

        phy0: ethernet-phy@0 {

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
m68k.org

In personal conversations with technical people, I call myself a hacker.
But when I'm talking to journalists I just say "programmer" or something
like that.
                                -- Linus Torvalds