On Wed, Jul 21, 2021 at 04:03:40PM +0200, Maxime Ripard wrote:
quoted hunk ↗ jump to hunk
The binding mentions that all the drivers using that driver must use a
vendor-specific compatible but never enforces it, nor documents the
vendor-specific compatibles.
Let's make we document all of them, and that the binding will create an
error if we add one that isn't.
Cc: <redacted>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sam Ravnborg <redacted>
Cc: Thierry Reding <redacted>
Signed-off-by: Maxime Ripard <redacted>
---
.../bindings/display/panel/lvds.yaml | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
index 49460c9dceea..d1513111eb48 100644
--- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
+++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
@@ -31,12 +31,18 @@ allOf:
properties:
compatible:
- contains:
- const: panel-lvds
- description:
- Shall contain "panel-lvds" in addition to a mandatory panel-specific
- compatible string defined in individual panel bindings. The "panel-lvds"
- value shall never be used on its own.
+ items:
+ - enum:
+ - advantech,idk-1110wr
At least this one is documented elsewhere. You can add 'minItems: 2' if
you want to just enforce having 2 compatibles. Or do:
items:
- {}
- const: panel-lvds
Which also enforces the order.
+ - advantech,idk-2121wr
+ - auo,b101ew05
+ - innolux,ee101ia-01d
+ - mitsubishi,aa104xd12
+ - mitsubishi,aa121td01
+ - sgd,gktw70sdae4se
+ - sharp,lq150x1lg11
+ - tbs,a711-panel
+ - const: panel-lvds
data-mapping:
enum:
--
2.31.1