On 7/2/21 5:15 PM, Rob Herring wrote:

On Fri, Jul 2, 2021 at 9:18 AM Rob Herring [off-list ref] wrote:

quoted

On Fri, Jul 02, 2021 at 11:07:57AM -0400, Sean Anderson wrote:

quoted

On 7/2/21 3:14 AM, Geert Uytterhoeven wrote:

quoted

Hi Sean,

On Thu, Jul 1, 2021 at 8:20 PM Sean Anderson [off-list ref] wrote:

quoted

These properties allow configuring the SD/OE pin as described in the
datasheet.

Signed-off-by: Sean Anderson <redacted>
---

Changes in v4:
- Specify that bindings should specify these properties, but don't make
  any guarantees about the driver's behavior when they are not present.
- Clarify description of idt,(en|dis)able-shutdown properties.
- Make opposing properties mutually exclusive.
- Add these properties to the example.

Thanks for the update!

quoted

--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
+++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml

quoted

@@ -109,6 +152,22 @@ allOf:
       required:
         - clock-names
         - clocks
+  - if:
+      true
+    then:
+      oneOf:
+        - required:
+            - idt,enable-shutdown
+        - required:
+            - idt,disable-shutdown
+  - if:
+      true
+    then:
+      oneOf:
+        - required:
+            - idt,output-enable-active-high
+        - required:
+            - idt,output-enable-active-low

Do you really need the "if: true then:"?
Just the "oneOf: ..." worked fine for me in another binding, but then I
didn't have a surrounding "allOf" to interfere...

Yes. If you want to have multiple oneOfs, they have to go under an
allOf. And allOf *only* allows if statements. This is a pretty big
deficiency, IMO, but not something I can address here.

Humm, we should relax that, not work around it.

I've now relaxed this restriction in dt-schema master.

Rob

P.S. I probably broke something because it's Friday afternoon before
going on holiday for a week (so I'll do a tagged release when back).

Will you be doing a release? I'm waiting on that before I send v5.

--Sean