Re: [PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile

On Thu, Jul 15, 2021 at 7:07 PM Marc Kleine-Budde [off-list ref] wrote:

On 15.07.2021 11:00:07, Joakim Zhang wrote:

quoted

quoted

I checked with Joakim that the flexcan on MX8MP is derived from MX6Q with
extra ECC added. Maybe we should still keep it from HW point of view?

Sorry, Aisheng, I double check the history, and get the below results:

8MP reuses 8QXP(8QM), except ECC_EN
(ipv_flexcan3_syn_006/D_IP_FlexCAN3_SYN_057 which corresponds to
version d_ip_flexcan3_syn.03.00.17.01)

Also see commit message of:

https://lore.kernel.org/linux-can/20200929211557.14153-2-qiangqing.zhang@nxp.com/ (local)

quoted

I prefer to change the dtsi as Mac suggested if possible, shall I send
a fix patch?

Make it so!

Then should it be "fsl,imx8mp-flexcan", "fsl,imx8qxp-flexcan" rather than only
drop "fsl,imx6q-flexcan"?

Regards
Aisheng

regards,
Marc

--
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |