Re: [PATCH 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-07-20 15:06:17
Also in:
linux-arm-kernel, lkml
On 20.07.2021 20:00:32, Aswath Govindraju wrote:
Hi Marc, On 20/07/21 7:50 pm, Marc Kleine-Budde wrote:quoted
On 20.07.2021 19:46:37, Aswath Govindraju wrote:quoted
From: Faiz Abbas <redacted> Add Support for two MCAN controllers present on the am65x SOC. Both support classic CAN messages as well as CAN-FD.Thanks for the patch! Why don't you disable the CAN cores by default in the dtsi?As far as I know, in the dtsi file we mention all the subsystems or periherals present in the SoC and in the specific board dts file we enable or disable the DT nodes depending on whether the pins are brought out.
If you disable the subsystems (that need pins) by default, you only have to list and configure only the used subsystems and not disable the unused ones. But it seems in the TI land you're following the rule you outlined above, so go ahead. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachments
- signature.asc [application/pgp-signature] 488 bytes