Thread (1 message) 1 message, 1 author, 2021-07-20

Re: [PATCH net-next v14 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

From: Lukasz Stelmach <l.stelmach@samsung.com>
Date: 2021-07-20 14:08:43
Also in: linux-arm-kernel, linux-samsung-soc, lkml, netdev

It was <2021-07-20 wto 12:36>, when Jakub Kicinski wrote:
On Mon, 19 Jul 2021 21:28:52 +0200, Łukasz Stelmach wrote:
quoted
+	ax_local->stats =
+		devm_netdev_alloc_pcpu_stats(&spi->dev,
+					     struct ax88796c_pcpu_stats);
+	if (!ax_local->stats)
+		return -ENOMEM;
+	u64_stats_init(&ax_local->stats->syncp);
../drivers/net/ethernet/asix/ax88796c_main.c:971:33: warning: incorrect type in argument 1 (different address spaces)
../drivers/net/ethernet/asix/ax88796c_main.c:971:33:    expected struct u64_stats_sync *syncp
../drivers/net/ethernet/asix/ax88796c_main.c:971:33:    got struct u64_stats_sync [noderef] __percpu *
Fixed, thanks.

Apparently separate u64_stats_init() is not necessary as
netdev_alloc_pcpu_stats() invokes it for_each_possible_cpu.

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help