Thread (40 messages) flat view 40 messages, 5 authors, 2021-07-30

Re: [PATCH v2 10/16] ASoC: qcom: audioreach: add bedai support

From: Srinivas Kandagatla <hidden>
Date: 2021-07-15 10:32:15
Also in: alsa-devel, lkml


On 14/07/2021 18:03, Pierre-Louis Bossart wrote:
quoted
+	rc = q6apm_graph_media_format_pcm(dai_data->graph[dai->id],
+					  substream->stream, cfg->sample_rate,
+					  cfg->num_channels, NULL, cfg->bit_width);
+
+	rc = q6apm_graph_prepare(dai_data->graph[dai->id]);
any good static analyzer would tell you you didn't test rc before overriding it..
yes you are correct, I did forgot to do cppcheck after make W=1 C=1

These are now fixed in new version.

--srini
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help