On Fri, Jul 09, 2021 at 08:41:35AM +0000, Nava kishore Manne wrote:

Hi Greg,

	Thanks for providing the review comments.
Please find my response inline.

quoted

-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org>
Sent: Wednesday, June 9, 2021 3:25 PM
To: Nava kishore Manne <redacted>
Cc: robh+dt@kernel.org; Michal Simek <redacted>;
mdf@kernel.org; trix@redhat.com; arnd@arndb.de; Rajan Vaja
[off-list ref]; Amit Sunil Dhamne [off-list ref];
Tejas Patel [off-list ref]; zou_wei@huawei.com; Sai Krishna
Potthuri [off-list ref]; Ravi Patel [off-list ref];
iwamatsu@nigauri.org; Jiaying Liang [off-list ref];
devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org; linux-fpga@vger.kernel.org; git [off-list ref];
chinnikishore369@gmail.com
Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API
support

On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote:

quoted

This patch adds user encrypted key load API to support User key
encrypted images loading use cases from Linux.

What is "user key encrypted images"?  Do we need more documentation
here for what this is and how to use it?

Xilinx bitstream writer, using AES, encrypts the bitstream. This feature allows user to encrypt bitstream using 256-bit AES encryption in cipher block chaining (CBC) mode.
User can supply a 128-bit Initial Vector and 256-bit key(user key).

Please provide the needed information in the changelog comment.

For more info please refer here: 
https://www.xilinx.com/support/documentation/application_notes/xapp1239-fpga-bitstream-encryption.pdf 

External links always grow stale.

thanks,

greg k-h