On Tue, Jul 06, 2021 at 07:00:17PM +0800, Tzung-Bi Shih wrote:
On Wed, Jun 30, 2021 at 3:28 PM kyrie.wu [off-list ref] wrote:
quoted
add component framework to using multi-HW for MT8195 jpeg encode.
Could you add some summary for each patch for getting an overview of the series?
quoted
dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible
media: mtk-jpegenc: Add MT8195 JPEG venc driver
media: mtk-jpegenc: remove redundant code of irq
media: mtk-jpegenc: Refactor jpeg clock interface
media: mtk-jpegenc: Generalize jpeg encode irq interfaces
media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces
media: mtk-jpegenc: Use component framework to manage each hardware
information
media: mtk-jpegenc: Generalize jpegenc HW operations interfaces
media: mtk-jpegenc: Refactor jpegenc device run interface
The series has some consistency issues which would make readers feel
uncomfortable.
For example:
- Whether to capitalize the first characters in the commit messages/titles.
- Whether to add a period at the end of English sentences.
FWIW, it's not customary to add a period at the end of a patch subject.
Best regards,
Tomasz