Hi Guido,

On Thu, Jul 08, 2021 at 05:13:13PM +0200, Guido Günther wrote:

On Thu, Jul 08, 2021 at 04:00:04PM +0300, Sakari Ailus wrote:

quoted

On Mon, Jun 28, 2021 at 12:10:54PM +0200, Martin Kepplinger wrote:

quoted

Build the driver for the Hi-846 camera by default on arm64 where it's
going to be used on at least the imx8mq-librem5 board.

Signed-off-by: Martin Kepplinger <redacted>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index f423d08b9a71..bf27d9cfbdd5 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig

@@ -666,6 +666,7 @@ CONFIG_VIDEO_RENESAS_VSP1=m
 CONFIG_VIDEO_QCOM_VENUS=m
 CONFIG_SDR_PLATFORM_DRIVERS=y
 CONFIG_VIDEO_RCAR_DRIF=m
+CONFIG_VIDEO_HI846=m
 CONFIG_VIDEO_IMX219=m
 CONFIG_VIDEO_OV5645=m
 CONFIG_VIDEO_QCOM_CAMSS=m

The same sensor may be or may not used on a given board (and certainly it's
not specific to arm64). Is it desirable all arm64 systems compile this in
by default?

There appear to be a other sensor drivers though.

Is there a defconfig for the librem5 board?

arm64 has a single defconfig, there are no board specific ones (and
afaik they're not wanted either) so I think enabling it as a module is
the only way.

Do sensor drivers qualify for defconfig support though ? If they do,
they should all be enabled.

quoted

I wonder what others think.

-- 
Regards,

Laurent Pinchart