Re: [PATCH v6 2/2] pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander
From: kernel test robot <hidden>
Date: 2021-06-25 04:51:37
Also in:
linux-gpio, oe-kbuild-all
Hi David, Thank you for the patch! Yet something to improve: [auto build test ERROR on pinctrl/devel] [also build test ERROR on robh/for-next v5.13-rc7 next-20210624] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/David-Bauer/dt-bindings-pinctrl-Add-bindings-for-Awinic-AW9523-AW9523B/20210625-055313 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel config: s390-allmodconfig (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/dd31385136eaa3a3feb0934f1e4ae4846a308c0c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review David-Bauer/dt-bindings-pinctrl-Add-bindings-for-Awinic-AW9523-AW9523B/20210625-055313 git checkout dd31385136eaa3a3feb0934f1e4ae4846a308c0c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All errors (new ones prefixed by >>): drivers/pinctrl/pinctrl-aw9523.c: In function 'aw9523_init_gpiochip':
quoted
drivers/pinctrl/pinctrl-aw9523.c:812:10: error: 'struct gpio_chip' has no member named 'of_node'
812 | gpiochip->of_node = dev->of_node;
| ^~
vim +812 drivers/pinctrl/pinctrl-aw9523.c
791
792 static int aw9523_init_gpiochip(struct aw9523 *awi, unsigned int npins)
793 {
794 struct device *dev = awi->dev;
795 struct gpio_chip *gpiochip = &awi->gpio;
796
797 gpiochip->label = devm_kstrdup(dev, dev_name(dev), GFP_KERNEL);
798 if (!gpiochip->label)
799 return -ENOMEM;
800
801 gpiochip->base = -1;
802 gpiochip->ngpio = npins;
803 gpiochip->get_direction = aw9523_gpio_get_direction;
804 gpiochip->direction_input = aw9523_direction_input;
805 gpiochip->direction_output = aw9523_direction_output;
806 gpiochip->get = aw9523_gpio_get;
807 gpiochip->get_multiple = aw9523_gpio_get_multiple;
808 gpiochip->set = aw9523_gpio_set;
809 gpiochip->set_multiple = aw9523_gpio_set_multiple;
810 gpiochip->set_config = gpiochip_generic_config;
811 gpiochip->parent = dev;
> 812 gpiochip->of_node = dev->of_node;
813 gpiochip->owner = THIS_MODULE;
814 gpiochip->can_sleep = false;
815
816 return 0;
817 }
818
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Attachments
- .config.gz [application/gzip] 28430 bytes