Re: [PATCH v4 03/10] dt-bindings: media: rkisp1: document different irq possibilities
From: Dafna Hirschfeld <hidden>
Date: 2021-06-17 07:17:59
Also in:
linux-media, linux-rockchip
Hi, On 17.06.21 00:52, Heiko Stuebner wrote:
quoted hunk ↗ jump to hunk
From: Heiko Stuebner <redacted> Some variants have one irq signaling all of MI, MIPI and ISP events while some rkisp1 variants use separate irqs for each. Adapt the binding to handle both cases. Signed-off-by: Heiko Stuebner <redacted> --- .../devicetree/bindings/media/rockchip-isp1.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml index 2f8f0625d22e..80709a01c6fd 100644 --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml@@ -21,7 +21,14 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + maxItems: 3 + + interrupt-names: + items: + - const: isp + - const: mi + - const: mipi
Since you use those names in the driver they should probably be 'required' you should do something like:
if:
properties:
compatible:
contains:
const: the-new-px30-compat..
then:
required:
- interrupt-names
would also be nice to add your new bindings in the example in the yaml
Thanks,
Dafna
clocks:
minItems: 3