Re: [PATCH v4 4/5] pinctrl: Add RTL8231 pin control and GPIO support
From: kernel test robot <hidden>
Date: 2021-06-03 15:59:07
Also in:
linux-gpio, linux-leds, oe-kbuild-all
Hi Sander, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pavel-linux-leds/for-next] [also build test WARNING on pinctrl/devel v5.13-rc4] [cannot apply to lee-mfd/for-mfd-next next-20210603] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sander-Vanheule/dt-bindings-leds-Binding-for-RTL8231-scan-matrix/20210603-190118 base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next config: sparc-allyesconfig (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/9c3e2b6957a6d750d6d39e78e2089abcc0cf740c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sander-Vanheule/dt-bindings-leds-Binding-for-RTL8231-scan-matrix/20210603-190118 git checkout 9c3e2b6957a6d750d6d39e78e2089abcc0cf740c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All warnings (new ones prefixed by >>): drivers/pinctrl/pinctrl-rtl8231.c: In function 'rtl8231_set_mux':
quoted
drivers/pinctrl/pinctrl-rtl8231.c:189:27: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
189 | unsigned int func_flag = (unsigned int) func->data;
| ^
vim +189 drivers/pinctrl/pinctrl-rtl8231.c
182
183 static int rtl8231_set_mux(struct pinctrl_dev *pctldev, unsigned int func_selector,
184 unsigned int group_selector)
185 {
186 const struct function_desc *func = pinmux_generic_get_function(pctldev, func_selector);
187 const struct rtl8231_pin_desc *desc = rtl8231_pins[group_selector].drv_data;
188 const struct rtl8231_pin_ctrl *ctrl = pinctrl_dev_get_drvdata(pctldev);
> 189 unsigned int func_flag = (unsigned int) func->data;
190 unsigned int function_mask;
191 unsigned int gpio_function;
192
193 if (!(desc->functions & func_flag))
194 return -EINVAL;
195
196 function_mask = BIT(desc->offset);
197 gpio_function = desc->gpio_function_value << desc->offset;
198
199 if (func_flag == RTL8231_PIN_FUNCTION_GPIO)
200 return regmap_update_bits(ctrl->map, desc->reg, function_mask, gpio_function);
201 else
202 return regmap_update_bits(ctrl->map, desc->reg, function_mask, ~gpio_function);
203 }
204
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Attachments
- .config.gz [application/gzip] 69644 bytes