Re: [PATCH RESEND v6 6/8] mfd: hi6421-spmi-pmic: move driver from staging
From: Lee Jones <hidden>
Date: 2021-06-28 10:44:03
Also in:
linux-staging, lkml
On Thu, 24 Jun 2021, Johan Hovold wrote:
On Thu, Jun 24, 2021 at 03:08:00PM +0100, Lee Jones wrote:quoted
On Thu, 24 Jun 2021, Mauro Carvalho Chehab wrote:quoted
Em Thu, 24 Jun 2021 12:33:28 +0100 Lee Jones [off-list ref] escreveu:quoted
quoted
quoted
quoted
--- /dev/null +++ b/drivers/mfd/hi6421-spmi-pmic.c@@ -0,0 +1,316 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Device driver for regulators in HISI PMIC IC + * + * Copyright (c) 2013 Linaro Ltd. + * Copyright (c) 2011 Hisilicon. + * Copyright (c) 2020-2021 Huawei Technologies Co., LtdCan this be updated?Do you mean updating the copyrights to cover this year? E.g. something like this: * Copyright (c) 2013-2021 Linaro Ltd. * Copyright (c) 2011-2021 Hisilicon. * Copyright (c) 2020-2021 Huawei Technologies Co., Ltd Right? Or are you meaning something else?Yes, that's it. I know this is just a move, but to MFD, it's new.That's not how copyright works. Unless Linaro and Hisilicon made nontrivial changes every year from 2011/2013 to 2021 you should not change those lines like this.
Thanks for the pointer. After receiving these, I went and did some reading-up on the subject, and you're quite right in what you say. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog