Re: [PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115

[PATCH v4 0/2] Add Pinctrl for SM4250 and SM6115 · Iskren Chernev <iskren.chernev@gmail.com> · 2021-06-25
[PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add SM6115 pinctrl bindings · Iskren Chernev <iskren.chernev@gmail.com> · 2021-06-25
Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add SM6115 pinctrl bindings · Bjorn Andersson <hidden> · 2021-06-25
[PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115 · Iskren Chernev <iskren.chernev@gmail.com> · 2021-06-25
Re: [PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115 · Konrad Dybcio <hidden> · 2021-06-25
Re: [PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115 · Bjorn Andersson <hidden> · 2021-06-25

From: Konrad Dybcio <hidden>
Date: 2021-06-25 23:39:53
Also in: linux-arm-msm, linux-gpio, lkml, phone-devel

+
+static const struct of_device_id sm6115_tlmm_of_match[] = {
+	{ .compatible = "qcom,sm4250-tlmm", },
+	{ .compatible = "qcom,sm6115-tlmm", },
+	{ }
+};

Please do not add separate compatibles for 2 speedbins of the otherwise same SoC.


Otherwise, the driver looks very good.


Konrad

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help