Re: [PATCH 1/4] MIPS: X1830: Respect cell count of common properties.
From: Paul Cercueil <hidden>
Date: 2021-06-22 12:31:22
Also in:
linux-mips, lkml
Hi Zhou, Le mar., juin 22 2021 at 15:37:22 +0800, 周琰杰 (Zhou Yanjie) [off-list ref] a écrit :
If N fields of X cells should be provided, then that's what the devicetree should represent, instead of having one single field of (N * X) cells. Signed-off-by: 周琰杰 (Zhou Yanjie) <redacted>
Acked-by: Paul Cercueil <paul@crapouillou.net> -Paul
quoted hunk ↗ jump to hunk
--- arch/mips/boot/dts/ingenic/x1830.dtsi | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)diff --git a/arch/mips/boot/dts/ingenic/x1830.dtsib/arch/mips/boot/dts/ingenic/x1830.dtsi index b21c930..59ca3a8 100644--- a/arch/mips/boot/dts/ingenic/x1830.dtsi +++ b/arch/mips/boot/dts/ingenic/x1830.dtsi@@ -97,9 +97,9 @@ #clock-cells = <1>; - clocks = <&cgu X1830_CLK_RTCLK - &cgu X1830_CLK_EXCLK - &cgu X1830_CLK_PCLK>; + clocks = <&cgu X1830_CLK_RTCLK>, + <&cgu X1830_CLK_EXCLK>, + <&cgu X1830_CLK_PCLK>; clock-names = "rtc", "ext", "pclk"; interrupt-controller;@@ -274,8 +274,7 @@ pdma: dma-controller@13420000 { compatible = "ingenic,x1830-dma"; - reg = <0x13420000 0x400 - 0x13421000 0x40>; + reg = <0x13420000 0x400>, <0x13421000 0x40>; #dma-cells = <2>; interrupt-parent = <&intc>; --2.7.4