Thread (7 messages) 7 messages, 2 authors, 2021-06-22

Re: [PATCH 2/4] MIPS: Loongson64: Add GMAC support for Loongson-2K1000

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-06-21 03:00:12
Also in: linux-mips, lkml, netdev

+			gmac@3,1 {
+				compatible = "pci0014,7a03.0",
+						   "pci0014,7a03",
+						   "pciclass0c0320",
+						   "pciclass0c03",
+						   "loongson, pci-gmac";
+
+				reg = <0x1900 0x0 0x0 0x0 0x0>;
+				interrupts = <14 IRQ_TYPE_LEVEL_LOW>,
+					     <15 IRQ_TYPE_LEVEL_LOW>;
+				interrupt-names = "macirq", "eth_lpi";
+				interrupt-parent = <&liointc0>;
+				phy-mode = "rgmii";
rgmii? But you set PHY_INTERFACE_MODE_GMII?
+				mdio {
+					#address-cells = <1>;
+					#size-cells = <0>;
+					compatible = "snps,dwmac-mdio";
+					phy1: ethernet-phy@1 {
+						reg = <0>;
The value after the @ should match the reg value.

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help