Re: [PATCH v3 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.

On Wed, Jun 16, 2021 at 9:24 PM 周琰杰 [off-list ref] wrote:

Hi Rob,

于 Wed, 16 Jun 2021 15:45:26 +0800
周琰杰 [off-list ref] 写道:

quoted

Hi Rob,

于 Tue, 15 Jun 2021 17:05:45 -0600
Rob Herring [off-list ref] 写道:

quoted

On Mon, Jun 14, 2021 at 11:18 AM 周琰杰 (Zhou Yanjie)
[off-list ref] wrote:

quoted

Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,
the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.

Signed-off-by: 周琰杰 (Zhou Yanjie) <redacted>
---

Notes:
    v1->v2:
    No change.

    v2->v3:
    Add "ingenic,mac.yaml" for Ingenic SoCs.

 .../devicetree/bindings/net/ingenic,mac.yaml       | 76
++++++++++++++++++++++ .../devicetree/bindings/net/snps,dwmac.yaml
| 15 +++++ 2 files changed, 91 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/net/ingenic,mac.yaml

diff --git
a/Documentation/devicetree/bindings/net/ingenic,mac.yaml
b/Documentation/devicetree/bindings/net/ingenic,mac.yaml new file
mode 100644 index 00000000..5fe2e81 --- /dev/null

+++ b/Documentation/devicetree/bindings/net/ingenic,mac.yaml

@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/ingenic,mac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bindings for MAC in Ingenic SoCs
+
+maintainers:
+  - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
+
+description:
+  The Ethernet Media Access Controller in Ingenic SoCs.
+
+properties:
+  compatible:
+    enum:
+      - ingenic,jz4775-mac
+      - ingenic,x1000-mac
+      - ingenic,x1600-mac
+      - ingenic,x1830-mac
+      - ingenic,x2000-mac
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    const: macirq
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: stmmaceth
+
+  mode-reg:
+    description: An extra syscon register that control ethernet

interface and timing delay

Needs a vendor prefix and type.

quoted

+
+  rx-clk-delay-ps:
+    description: RGMII receive clock delay defined in pico
seconds +
+  tx-clk-delay-ps:
+    description: RGMII transmit clock delay defined in pico
seconds +
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+  - clocks
+  - clock-names
+  - mode-reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/x1000-cgu.h>
+
+    mac: ethernet@134b0000 {
+        compatible = "ingenic,x1000-mac", "snps,dwmac";

Doesn't match the schema.

Sorry for that, somehow when I run "make dt_bindings_check", there is
no warrning or error message about this file. I am sure that yamllint
is installed and dtschema has been upgraded to 2021.6.

I found that it seems to be because 5.13 newly introduced
"DT_CHECKER_FLAGS=-m", and I am still using the old
"make dt_binding_check" command, so this error is not prompted. Now I
can see this error message after using the
"make DT_CHECKER_FLAGS=-m dt_binding_check" command, and I will send a
fix soon.

No, this error has nothing to do with the '-m' option.

Rob