Hi Ezequiel,

Am 11.06.21 um 17:50 schrieb Ezequiel Garcia:

Hi Alex,

On Thu, 2021-05-27 at 17:44 +0200, Alex Bee wrote:

quoted

RK3066's VPU IP block is the predecessor from what RK3288 has.
The hardware differences are:
   - supports decoding frame sizes up to 1920x1088 only
   - doesn't have the 'G1_REG_SOFT_RESET' register
     (requires another .reset callback for hantro_codec_ops,
      since writing this register will result in non-working
      IP block)
   - has one ACLK/HCLK per vdpu/vepu
   - ACLKs can be clocked up to 300 MHz only

Have you tested trying 400 MHz (or more) ?

Yes, I've tried this on both RK3066 and RK3036 variants - everything 
above  300 MHz results in non-functioning IP block.

See comment in RK3036 devicetree in vendor kernel at [1].

[1] 
https://github.com/rockchip-linux/kernel/blob/develop-4.4/arch/arm/boot/dts/rk3036.dtsi#L246-L248

quoted

   - no MMU
     (no changes required: CMA will be transparently used)

Add a new RK3066 variant which reflect this differences. This variant
can be used for RK3188 as well.

Reviewed-by: Ezequiel Garcia <redacted>

Thanks!
Ezequiel