Re: [PATCH 1/8] dt-bindings: arm/npcm: Add binding for global control registers (GCR)

On Fri, Jun 04, 2021 at 10:00:18AM +0200, Linus Walleij wrote:

On Wed, Jun 2, 2021 at 2:04 PM Jonathan Neuschäfer
[off-list ref] wrote:

quoted

A nuvoton,*-gcr node is present in nuvoton-common-npcm7xx.dtsi and will
be added to nuvoton-wpcm450.dtsi. It is necessary for the NPCM7xx and
WPCM450 pinctrl drivers, and may later be used to retrieve SoC model and
version information.

This patch adds a binding to describe this node.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

(...)

quoted

+    gcr: gcr@800000 {
+      compatible = "nuvoton,npcm750-gcr", "syscon", "simple-mfd";
+      reg = <0x800000 0x1000>;
+    };

gcr looks a bit idiomatic, isn't

syscon:  syscon@... better?

I think I'll go with syscon@..., because it's the right generic name,
but gcr for the label, matching current usage.

Nitpicky though and looks good to me either way:
Reviewed-by: Linus Walleij <redacted>

Thanks!


Jonathan Neuschäfer