Re: [PATCH 3/3] soc: mediatek: pm-domains: Add support for mt8195
flat view
From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2021-06-10 08:50:31
Also in:
linux-arm-kernel, linux-mediatek, lkml
Hi Chun-Jie, Thanks for the patch, comments below. On 10/06/2021 04:36, Chun-Jie Chen wrote:
From: "chun-jie.chen" <redacted> Add the needed board data to support mt8195 SoC.
Please try to come up with a better commit message. Especially mention that we have to increase the SPM_MAX_BUS_PROT_DATA.
Signed-off-by: chun-jie.chen <redacted>
I suppose your name would be "Chun-Jie Chen" Please also fix your git settings to that From and Signed-off-by matches. [...]
quoted hunk
diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h index 8b86ed22ca56..1b8967b9829e 100644 --- a/drivers/soc/mediatek/mtk-pm-domains.h +++ b/drivers/soc/mediatek/mtk-pm-domains.h@@ -37,7 +37,7 @@ #define PWR_STATUS_AUDIO BIT(24) #define PWR_STATUS_USB BIT(25) -#define SPM_MAX_BUS_PROT_DATA 5 +#define SPM_MAX_BUS_PROT_DATA 6 #define _BUS_PROT(_mask, _set, _clr, _sta, _update, _ignore) { \ .bus_prot_mask = (_mask), \@@ -72,8 +72,6 @@ struct scpsys_bus_prot_data { bool ignore_clr_ack; }; -#define MAX_SUBSYS_CLKS 10 -
Good catch, not needed define. Can you put that in a new patch please? Regards, Matthias