Thread (39 messages) flat view 39 messages, 5 authors, 2021-06-10

Re: [PATCH v22 12/18] memory: pl353-smc: Let lower level controller drivers handle inits

From: Krzysztof Kozlowski <hidden>
Date: 2021-06-09 11:54:35
Also in: linux-arm-kernel, lkml

On 09/06/2021 10:01, Miquel Raynal wrote:
There is no point in having all these definitions at the SMC bus level,
these are extremely tight to the NAND controller driver implementation,
are not particularly generic, imply more boilerplate than needed, do
not really follow the device model by receiving no argument and some of
them are actually buggy.

Let's get rid of these right now as there is no current user and keep
this driver at a simple level: only the SMC bare initializations.

The NAND controller driver which I am going to introduce will take care
of redefining properly all these helpers and using them directly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/memory/pl353-smc.c | 294 -------------------------------------
 include/linux/pl353-smc.h  |  30 ----
 2 files changed, 324 deletions(-)
 delete mode 100644 include/linux/pl353-smc.h
I see you remove here a bunch of code. Are the series still fully
bisectable?


Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help