Am Dienstag, dem 08.06.2021 um 00:15 +0300 schrieb Laurent Pinchart:

Hi Martin

Thank you for the patch.

On Mon, Jun 07, 2021 at 12:52:10PM +0200, Martin Kepplinger wrote:

quoted

Document the bindings used for the SK Hynix Hi-846 CMOS camera
driver.

Signed-off-by: Martin Kepplinger <redacted>
---
 .../bindings/media/i2c/hynix,hi846.yaml       | 105
++++++++++++++++++
 1 file changed, 105 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml

diff --git
a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
new file mode 100644
index 000000000000..19825392fb1f

--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml

@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/hynix,hi846.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SK Hynix Hi-846 1/4" 8M Pixel MIPI CSI-2 sensor
+
+maintainers:
+  - Martin Kepplinger <martin.kepplinger@puri.sm>
+
+description: |-
+  The Hi-846 is a raw image sensor with an MIPI CSI-2 image data
+  interface and CCI (I2C compatible) control bus. The output

format
+  is raw Bayer.
+
+properties:
+  compatible:
+    const: hynix,hi846
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: Reference to the mclk clock.
+
+  reset-gpios:
+    description: Reference to the GPIO connected to the RESETB
pin. Active low.
+    maxItems: 1
+
+  shutdown-gpios:
+    description: Reference to the GPIO connected to the XSHUTDOWN
pin. Active low.
+    maxItems: 1
+
+  vddi-supply:

I think it's called vddio (seems to be a typo on page 8).

quoted

+    description: Definition of the regulator used for the 1.8V or
2.8V I/O power supply.

You could just say "... for the VDDIO supply". Same below. Up to you.

With the name fixed and the description optionally updated,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Please add my tag if you post a new version.

I'll rename the binding and add the tag. I haven't added your previous
tag because you found improvements based on the DS afterwards.

thanks again!
                              martin