Thread (18 messages) 18 messages, 4 authors, 2021-06-09

Re: [PATCH v3 3/5] gpio: gpio-aspeed-sgpio: Add AST2600 sgpio support

From: Andy Shevchenko <hidden>
Date: 2021-06-04 10:23:02
Also in: linux-arm-kernel, linux-aspeed, linux-gpio, lkml

On Fri, Jun 4, 2021 at 5:14 AM Steven Lee [off-list ref] wrote:
The 06/03/2021 19:05, Andy Shevchenko wrote:
quoted
On Thu, Jun 3, 2021 at 1:19 PM Steven Lee [off-list ref] wrote:
quoted
quoted
+#define GPIO_OFFSET(x)        ((x) & 0x1f)
GENMASK()

...
Do you mean the macro should be modified as follows?
#define GPIO_OFFSET(x)        ((x) & GENMASK(4, 0))
Yes.

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help