Re: [PATCH v2 1/2] dt-bindings: pci: Add DT bindings for apple,pcie
From: Rob Herring <robh@kernel.org>
Date: 2021-06-01 20:33:21
Also in:
linux-arm-kernel, linux-pci, lkml
From: Rob Herring <robh@kernel.org>
Date: 2021-06-01 20:33:21
Also in:
linux-arm-kernel, linux-pci, lkml
On Tue, Jun 01, 2021 at 08:32:10AM -0500, Rob Herring wrote:
On Mon, 31 May 2021 00:44:00 +0200, Mark Kettenis wrote:quoted
From: Mark Kettenis <redacted> The Apple PCIe host controller is a PCIe host controller with multiple root ports present in Apple ARM SoC platforms, including various iPhone and iPad devices and the "Apple Silicon" Macs. Signed-off-by: Mark Kettenis <redacted> --- .../devicetree/bindings/pci/apple,pcie.yaml | 167 ++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 168 insertions(+) create mode 100644 Documentation/devicetree/bindings/pci/apple,pcie.yamlMy bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/pci/apple,pcie.example.dts:20:18: fatal error: dt-bindings/pinctrl/apple.h: No such file or directory 20 | #include <dt-bindings/pinctrl/apple.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Looking at the example, I don't think you need this header. Looks like irq.h is needed though. Otherwise, LGTM. Rob