Thread (11 messages) flat view 11 messages, 3 authors, 2021-05-27

Re: [PATCH 3/3] ASoC: rsnd: add null CLOCKIN support

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: 2021-05-26 22:06:22
Also in: alsa-devel

Hi Geert
Oh right, I missed the static clk_hw pointer.
What if you unload the snd-soc-rcar.ko module?
Hmm.. indeed.
It needs something..
Thank you for poining it.
    #define for_each_rsnd_clk(pos, adg, i)          \
            for (i = 0; (pos) = adg->clk[i], i < CLKMAX; i++)            \
                    if (pos) {                      \
                            continue;               \
                    } else
Wow!! I didn't know this technique.
Indeed it can use NULL pointer.

But, I want to avoid "if (pos) else" code as much as possible,
and keep simple code.
It can handle all clk case without thinking it if it has null_clk.

Why you don't want null_clk ??

Thank you for your help !!

Best regards
---
Kuninori Morimoto
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help