Re: [PATCH 3/3] dt-bindings: gpio: pcf857x: Convert to json-schema
From: Linus Walleij <hidden>
Date: 2021-05-21 10:04:32
Also in:
linux-arm-kernel, linux-gpio, linux-omap
On Fri, May 21, 2021 at 9:54 AM Geert Uytterhoeven [off-list ref] wrote:
Convert the PCF857x-compatible I/O expanders Device Tree binding documentation to json-schema. Document missing compatible values, properties, and gpio hogs. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
(...)
Perhaps the "ti,pcf8575" construct should be removed, and the few users fixed instead?
You would rather list it as deprecated I think? It is ABI...
+ gpio-controller: true
So this is implicitly using the generic schema in /dtschema/schemas/gpio/gpio.yaml
+ lines-initial-states: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Bitmask that specifies the initial state of each line. + When a bit is set to zero, the corresponding line will be initialized to + the input (pulled-up) state. + When the bit is set to one, the line will be initialized to the + low-level output state. + If the property is not specified all lines will be initialized to the + input state.
Is this something we standardized or something that should actually be a custom "nxp," property we just missed it? (Looks like the latter... oh well, now it is there.)
+patternProperties: + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": + type: object
But this is already in /dtschema/schemas/gpio/gpio-hog.yaml for nodename, isn't that where it properly belongs? I'm however confused here Rob will know what to do.
required: - gpio-hog - gpios
This is already in /dtschema/schemas/gpio/gpio-hog.yaml as well? Yours, Linus Walleij