Re: [PATCH 2/2] dt-bindings: serial: pl011: Avoid matching device tree nodes of variant pl011 drivers
From: Leizhen (ThunderTown) <hidden>
Date: 2021-05-21 01:30:01
Also in:
linux-serial
On 2021/5/20 19:54, Zhen Lei wrote:
There is a variant driver of pl011, which may have a compatible string written as: "arm,sbsa-uart", "arm,pl011". Because it contains "arm,pl011", so the corresponding device tree nodes are also checked by this YAML file. As a result, many flase warnings similar to the following are reported: arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dt.yaml: serial@21c0000: compatible:0: 'arm,pl011' was expected serial@21c0000: compatible:1: 'arm,primecell' was expected Change to only check the device tree nodes that are matched exactly.
Hi, all: This morning I rethought, and there's something wrong with this change. The compatibles that are incorrectly written cannot be identified, for example, only "arm,pl011". I'll think of something else.
quoted hunk ↗ jump to hunk
Signed-off-by: Zhen Lei <redacted> --- Documentation/devicetree/bindings/serial/pl011.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml index 5ea00f8a283d..3683e4567645 100644 --- a/Documentation/devicetree/bindings/serial/pl011.yaml +++ b/Documentation/devicetree/bindings/serial/pl011.yaml@@ -16,9 +16,9 @@ allOf: select: properties: compatible: - contains: - enum: - - arm,pl011 + items: + - const: arm,pl011 + - const: arm,primecell required: - compatible