Re: [PATCH v11 1/4] mfd: Add Rockchip rk817 audio CODEC support
From: Lee Jones <hidden>
Date: 2021-05-19 14:41:06
Also in:
alsa-devel, linux-rockchip
On Fri, 14 May 2021, Chris Morgan wrote:
quoted hunk ↗ jump to hunk
From: Chris Morgan <redacted> Add rk817 codec support cell to rk808 mfd driver. Signed-off-by: Chris Morgan <redacted> Tested-by: Maciej Matuszczyk <redacted> --- drivers/mfd/rk808.c | 83 +++++++++++++++++++++++++++++++++++++++ include/linux/mfd/rk808.h | 81 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 164 insertions(+)diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c index ad923dd4e007..b94f805719a6 100644 --- a/drivers/mfd/rk808.c +++ b/drivers/mfd/rk808.c@@ -65,6 +65,7 @@ static bool rk817_is_volatile_reg(struct device *dev, unsigned int reg) switch (reg) { case RK817_SECONDS_REG ... RK817_WEEKS_REG: case RK817_RTC_STATUS_REG: + case RK817_CODEC_DTOP_LPT_SRST: case RK817_INT_STS_REG0: case RK817_INT_STS_REG1: case RK817_INT_STS_REG2:@@ -163,6 +164,9 @@ static const struct mfd_cell rk817s[] = { .num_resources = ARRAY_SIZE(rk817_rtc_resources), .resources = &rk817_rtc_resources[0], }, + { + .name = "rk817-codec", + },
This should be on a single line please. Once fixed, please apply my: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones [off-list ref] -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog