Re: [PATCH v1 1/2] dt-bindings: rtc: microchip: Add Microchip PolarFire host binding
From: Rob Herring <robh@kernel.org>
Date: 2021-05-13 02:22:54
Also in:
linux-rtc
On Wed, May 12, 2021 at 12:11:32PM +0100, daire.mcnamara@microchip.com wrote:
quoted hunk ↗ jump to hunk
From: Daire McNamara <daire.mcnamara@microchip.com> Add device tree bindings for the Microchip PolarFire real-time clock controller Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com> --- .../bindings/rtc/microchip,mfps-rtc.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yamldiff --git a/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml new file mode 100644 index 000000000000..c82b3e7351e0 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml@@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/microchip,mfps-rtc.yaml# + +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip PolarFire Soc (MPFS) RTC Device Tree Bindings + +allOf: + - $ref: "rtc.yaml#" + +maintainers: + - Daire McNamara <daire.mcnamara@microchip.com> + - Lewis Hanly <lewis.hanly@microchip.com> + +properties: + compatible: + enum: + - microchip,mpfs-rtc + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + prescaler: + maxItems: 1
An array? Needs a type, constraints, and vendor prefix.
+ + clocks: + maxItems: 1 + + clock-names: + items: + - const: rtc
Kind of a pointless name. You don't need *-names when there is only 1.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/microchip,mpfs-clock.h>
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ rtc@20124000 {
+ compatible = "microchip,mpfs-rtc";
+ reg = <0 0x20124000 0 0x1000>;
+ clocks = <&clkcfg CLK_RTC>;
+ clock-names = "rtc";
+ interrupts = <80>;
+ };
+ };
+...
--
2.25.1