Re: #regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data for dra7 sata")

On Fri, 7 May 2021 at 13:57, Thorsten Leemhuis [off-list ref] wrote:

On 07.05.21 10:02, Tony Lindgren wrote:

quoted

* Naresh Kamboju [off-list ref] [210506 15:19]:

quoted

On Thu, 6 May 2021 at 17:23, Tony Lindgren [off-list ref] wrote:

quoted

* Naresh Kamboju [off-list ref] [210506 11:00]:

quoted

Our bisect script pointed this as the first bad commit on linux
mainline master branch.
commit 98feab31ac491400f28b76a04dabd18ce21e91ba
Author: Tony Lindgren [off-list ref]
Date:   Wed Mar 10 14:03:51 2021 +0200
    ARM: OMAP2+: Drop legacy platform data for dra7 sata

Thanks for the report, looks like we are now missing the sata related
quirk flags compared to the patch above.
Below is a quick patch to add the missing quirk flags that might help
if you can give it a try.

The reported problem was solved by this patch. Thank you.
Please add reported and tested by tags.
Reported-by: Naresh Kamboju <redacted>
Tested-by: Naresh Kamboju <redacted>

OK good to hear and thanks for testing. Will send out a proper patch.

Great to see that this is about to be fixed. And Naresh, many thx for
giving the #regzb tag a try, even if regzbot (shameless plug for the
unaware: https://linux-regtracking.leemhuis.info/post/regzbot-approach/
) is not up and running already, much appreciated!

But FWIW, you don't need to add the tag to the subject; in fact, better
use it for it's intended purpose. Instead add the tag to the mail's
body, like this:

#regzb introduced: 98feab31ac49 ("ARM: OMAP2+: Drop legacy platform data
for dra7 sata")

Thanks for sharing more details about it.
Next time I will add this to the mail's body.

Just ensure there is a blank line after that, as regzbot will have to
deal with line breaks (as can be seen above) and somehow needs to decide
where to stop. ;-)

Alright.

Ohh, and Tony, if you want to do me a favour please include

Link:
https://lore.kernel.org/regressions/CA+G9fYtTN6ug3eBAW3wMcDeESUo+ebj7L5HBe5_fj4uqDExFQg@mail.gmail.com/ (local)

in the commit message of the fix, then I have some real data already at
hand to test regzbot in practice. :-D

- Naresh