Re: [PATCH net-next 4/4] staging: mt7621-dts: enable MT7530 interrupt controller
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-05-06 11:48:27
Also in:
linux-mediatek, linux-staging, lkml, netdev
On Thu, Apr 29, 2021 at 02:21:30PM +0800, DENG Qingfang wrote:
quoted hunk ↗ jump to hunk
Enable MT7530 interrupt controller in the MT7621 SoC. Signed-off-by: DENG Qingfang <dqfext@gmail.com> --- RFC v4 -> PATCH v1: - No changes. drivers/staging/mt7621-dts/mt7621.dtsi | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi index 16fc94f65486..0f7e487883a5 100644 --- a/drivers/staging/mt7621-dts/mt7621.dtsi +++ b/drivers/staging/mt7621-dts/mt7621.dtsi@@ -447,6 +447,10 @@ switch0: switch0@0 { mediatek,mcm; resets = <&rstctrl 2>; reset-names = "mcm"; + interrupt-controller; + #interrupt-cells = <1>; + interrupt-parent = <&gic>; + interrupts = <GIC_SHARED 23 IRQ_TYPE_LEVEL_HIGH>; ports { #address-cells = <1>;-- 2.25.1
I don't remember if I mentioned this before, but a short-hand way of expressing this is using: interrupts-extended = <&gic GIC_SHARED 23 IRQ_TYPE_LEVEL_HIGH>; but the entire drivers/staging/mt7621-dts/mt7621.dtsi file uses interrupt-parent, so this is fine. Also, I panicked for a second thinking that this is the ARM GIC which supports the GIC_SHARED flag, but I see that mt7621 is MIPS. Reviewed-by: Vladimir Oltean <olteanv@gmail.com>