Re: [PATCH 2/2] arm64: dts: qcom: sc7280: Add cpu OPP tables
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2021-05-05 11:37:32
Also in:
linux-arm-msm, linux-pm, lkml
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2021-05-05 11:37:32
Also in:
linux-arm-msm, linux-pm, lkml
On 05-05-21, 09:49, Sudeep Holla wrote:
No my main concern is this platform uses "qcom-cpufreq-hw" driver and the fact that the OPPs are retrieved from the hardware lookup table invalidates whatever we have in DT.
Not exactly. It disables them all, and then call dev_pm_opp_adjust_voltage() and enable them again. This is how it started initially. Though the driver also works if the DT doesn't have the table, in that case it calls dev_pm_opp_add() for all the OPPs.
In short it will be junk and becomes obsolete. So what I suggested before is still valid. You simply can't have static OPP tables in the DT for this platform. Do get some boot code to fetch the same from the h/w LUT and patch to the DT or figure out any other way to manage dynamically. So NACK still stands for static addition of OPPs to the DT as in this patch.
-- viresh