Re: [PATCH v3 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2021-05-31 23:13:59
Also in:
linux-media, lkml, phone-devel
Hi Martin, Thank you for the patch. On Mon, May 31, 2021 at 02:07:34PM +0200, Martin Kepplinger wrote:
quoted hunk ↗ jump to hunk
Document the bindings used for the SK Hynix Hi-846 CMOS camera driver. Signed-off-by: Martin Kepplinger <redacted> --- .../bindings/media/i2c/hynix,hi846.yaml | 99 +++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/hynix,hi846.yamldiff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml new file mode 100644 index 000000000000..26462f6b5e69 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml@@ -0,0 +1,99 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/hynix,hi846.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: SK Hynix Hi-846 1/4" 8M Pixel MIPI CSI-2 sensor + +maintainers: + - Martin Kepplinger <martin.kepplinger@puri.sm> + +description: |- + The Hi-846 is a raw image sensor with an MIPI CSI-2 image data + interface and CCI (I2C compatible) control bus. The output format + is 10bit Bayer. + +properties: + compatible: + const: hynix,hi846 + + reg: + maxItems: 1 + + clocks: + items: + - description: Reference to the mclk clock. + + clock-names: + items: + - const: mclk + + reset-gpios: + description: Reference to the GPIO connected to the reset pin. Active low. + maxItems: 1 + + vdd-supply: + description: Definition of the regulator used as 1.8V digital power supply. + + port: + $ref: /schemas/graph.yaml#/properties/port + additionalProperties: false
You can drop the additionalProperties, the graph schema has unevaluatedProperties set to false already.
+ + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + oneOf: + - items: + - const: 1 + - const: 2 + - const: 3 + - const: 4 + - items: + - const: 1 + - const: 2 + + required: + - data-lanes + +required: + - compatible + - reg + - clocks + - clock-names + - reset-gpios
I'd keep the reset-gpios property optional, in case the signal is hardwired. I don't have access to the sensor datasheet, so I can't provide comments on what may be missing. With the above two issues addressed, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+ - vdd-supply
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hi846: camera@20 {
+ compatible = "hynix,hi846";
+ reg = <0x20>;
+ clocks = <&clk>;
+ clock-names = "mclk";
+ vdd-supply = <®_camera_pwr_en>; /* 1.8v */
+ reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+
+ port {
+ camera_out: endpoint {
+ remote-endpoint = <&csi1_ep1>;
+ data-lanes = <1 2>;
+ };
+ };
+ };
+ };
+
+...-- Regards, Laurent Pinchart