On Wed 26 May 18:30 CDT 2021, Stephen Boyd wrote:

Quoting Maulik Shah (2021-05-21 04:26:09)

quoted

Add device node for SoC sleep stats driver which provides various
low power mode stats.

Also update the reg size of aoss_qmp device to 0x400.

Cc: devicetree@vger.kernel.org
Signed-off-by: Maulik Shah <redacted>
Reviewed-by: Bjorn Andersson <redacted>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 6228ba2..889d04d 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi

@@ -3215,7 +3215,7 @@

                aoss_qmp: power-controller@c300000 {
                        compatible = "qcom,sc7180-aoss-qmp";
-                       reg = <0 0x0c300000 0 0x100000>;
+                       reg = <0 0x0c300000 0 0x400>;
                        interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
                        mboxes = <&apss_shared 0>;

@@ -3223,6 +3223,11 @@
                        #power-domain-cells = <1>;
                };

+               rpmh-sleep-stats@c3f0000 {
+                       compatible = "qcom,rpmh-sleep-stats";
+                       reg = <0 0x0c3f0000 0 0x400>;
+               };
+

Does this need to be in DT? Can the sc7180-aoss-qmp driver use the
aux-bus and stick the sleep stats device on there?

The AOSS memory space has N chunks of "message ram", one is used for the
QMP protocol (presumably the APSS specific one), a different one is used
for the sleep stats.

I presume we could have come up with a binding for the entire AOSS/AOP
and then describe (either implicit or explicitly) the QMP and
debug-stats under that.

But we'd also have to come up with the same container-device for the RPM
case.

Regards,
Bjorn

quoted

                spmi_bus: spmi@c440000 {
                        compatible = "qcom,spmi-pmic-arb";
                        reg = <0 0x0c440000 0 0x1100>,