Re: [PATCH v2 1/3] arm64: dts: qcom: Add PMI8996 DTSI file
From: Bjorn Andersson <hidden>
Date: 2021-05-31 17:14:07
Also in:
linux-arm-msm, lkml
On Thu 27 May 12:04 CDT 2021, Konrad Dybcio wrote:
PMI8996 is *almost* the same hardware as PMI8994, say for some annoyances: - Boards equipped with PMI8996 now have to include pmic-id (which wasn't the case before) - Different qpnp-ibb-discharge-resistor value (will be addressed after LABIBB is introduced) - Different inhibit-derating-ua value (will be addressed after BCL is introduced) - Different ramp_up_step value (will be addressed after [if?] QPNP Flash LED is introduced)
If I am to support a device that has a pmi8996, I will go #include "pmi8996.dtsi" and wonder why it didn't work. But, I do see the validity in your argumentation in the previous revision so I won't object. But I really would like you to describe in the commit message why this is different from what people would expect to find.
quoted hunk ↗ jump to hunk
Signed-off-by: Konrad Dybcio <redacted> --- arch/arm64/boot/dts/qcom/pmi8996.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/pmi8996.dtsidiff --git a/arch/arm64/boot/dts/qcom/pmi8996.dtsi b/arch/arm64/boot/dts/qcom/pmi8996.dtsi new file mode 100644 index 000000000000..31b47209e261 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/pmi8996.dtsi@@ -0,0 +1,15 @@ +// SPDX-License-Identifier: GPL-2.0
And BSD please :) Regards, Bjorn
+/*
+ * Copyright (c) 2021, Konrad Dybcio [off-list ref]
+ */
+
+ /*
+ * PMI8996 is a slight modification of PMI8994 with
+ * some notable changes, like being the first PMIC
+ * whose the bootloader has to check to continue booting
+ * and a change to a LABIBB parameter.
+ */
+
+/ {
+ qcom,pmic-id = <0x20009 0x10013 0 0>;
+};
--
2.31.1