Hi Mark,

I have submiited the v2 patch. Thanks for the feedback too.

On Thu, May 27, 2021 at 02:05:53PM +0100, Mark Brown wrote:

On Thu, May 27, 2021 at 08:51:27AM -0300, Ezequiel Garcia wrote:

quoted

On Thu, 2021-05-27 at 10:59 +0000, Rudi Heitbaum wrote:

quoted

quoted

+       /delete-property/ operating-points-v2;

quoted

Removal of the operating points kind of makes the gpu regulator moot,
don't you think?

It's still better to say what the supply is even if it can't be
changed - that stops you getting warnings about substituting in a
dummy regulator and allows the consumer to read the current state
of the regulator in case that's useful.

I'll look into this.
Thank you all for the feedback and direction on the dts.

quoted

quoted

+???????????????regulator-compatible = "fan53555-reg";

quoted

I can be wrong, but I think regulator-compatible is deprecated.

Yes.

will action

quoted

quoted

+???????????????regulator-boot-on;

quoted

Just out of curiosity, is regulator-boot-on really needed for the GPU?

It should only be used if it's not possible to read the state of
the regulator enable from the hardware.

will do further testing