Re: [v4 4/4] drm/panel-simple: Add Samsung ATNA33XC20
From: Doug Anderson <dianders@chromium.org>
Date: 2021-05-25 17:20:06
Also in:
dri-devel, linux-arm-msm, lkml
Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add Samsung 13.3" FHD eDP AMOLED panel. Signed-off-by: Rajeev Nandan <redacted> --- Changes in v4: - New drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index caed71b..21af794 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c@@ -3644,6 +3644,37 @@ static const struct panel_desc rocktech_rk101ii01d_ct = { .connector_type = DRM_MODE_CONNECTOR_LVDS, }; +static const struct drm_display_mode samsung_atna33xc20_mode = { + .clock = 138770, + .hdisplay = 1920, + .hsync_start = 1920 + 48, + .hsync_end = 1920 + 48 + 32, + .htotal = 1920 + 48 + 32 + 80, + .vdisplay = 1080, + .vsync_start = 1080 + 8, + .vsync_end = 1080 + 8 + 8, + .vtotal = 1080 + 8 + 8 + 16, + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC, +}; + +static const struct panel_desc samsung_atna33xc20 = { + .modes = &samsung_atna33xc20_mode, + .num_modes = 1, + .bpc = 10, + .size = { + .width = 294, + .height = 165, + }, + .delay = { + .disable_to_power_off = 150, + .power_to_enable = 150, + .hpd_absent_delay = 200, + .unprepare = 500, + }, + .connector_type = DRM_MODE_CONNECTOR_eDP, + .uses_dpcd_backlight = true,
From my feedback on the previous patch in this series, I believe the "uses_dpcd_backlight" property should be removed and this should be auto-detected. Other than that this patch looks fine to me. Feel free to add my Reviewed-by tag next spin when that property is removed.