Re: [PATCH v4,6/6] media: mtk-vcodec: Support MT8192 H264 4K encoding
From: Tzung-Bi Shih <hidden>
Date: 2021-05-21 08:06:47
Also in:
linux-arm-kernel, linux-media, linux-mediatek, lkml
On Fri, May 21, 2021 at 3:02 PM Irui Wang [off-list ref] wrote:
fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE; - fsize->stepwise = mtk_venc_framesizes; + fsize->stepwise = + (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) ? + mtk_venc_4k_framesizes : mtk_venc_hd_framesizes;
Use a normal if .. else .. is more readable.
quoted hunk ↗ jump to hunk
@@ -1210,6 +1231,9 @@ int mtk_vcodec_enc_ctrls_setup(struct mtk_vcodec_ctx *ctx) { const struct v4l2_ctrl_ops *ops = &mtk_vcodec_enc_ctrl_ops; struct v4l2_ctrl_handler *handler = &ctx->ctrl_hdl; + const u8 h264_max_level = + (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) ? + V4L2_MPEG_VIDEO_H264_LEVEL_5_1 : V4L2_MPEG_VIDEO_H264_LEVEL_4_2;
Again, I would like it to be a normal if .. else ..