RE: [PATCH V2 08/18] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work
From: Aisheng Dong <aisheng.dong@nxp.com>
Date: 2021-05-21 06:43:34
Also in:
linux-arm-kernel, linux-i2c, lkml
From: Clark Wang <xiaoning.wang@nxp.com> Sent: Tuesday, April 6, 2021 7:33 PM add debug message when i2c peripheral clk rate is 0, then directly return -EINVAL. Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
You sign-off should be put after the original patch author
Signed-off-by: Gao Pan <redacted> Reviewed-by: Andy Duan <redacted>
Drop the original review when they're significant changes
quoted hunk ↗ jump to hunk
--- V2 changes: - Add my signed-off. --- drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.cb/drivers/i2c/busses/i2c-imx-lpi2c.c index 333209ba81c1..dfec334712c2 100644--- a/drivers/i2c/busses/i2c-imx-lpi2c.c +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c@@ -210,6 +210,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct*lpi2c_imx) lpi2c_imx_set_mode(lpi2c_imx); clk_rate = clk_get_rate(lpi2c_imx->clk_per); + if (!clk_rate) { + dev_dbg(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n");
s/dev_dbg/dev_err
+ return -EINVAL; + } + if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST) filt = 0; else -- 2.25.1