Re: [PATCH net-next v2 1/4] net: phy: add MediaTek Gigabit Ethernet PHY driver
From: DENG Qingfang <dqfext@gmail.com>
Date: 2021-05-20 02:39:05
Also in:
linux-mediatek, linux-staging, lkml, netdev
On Thu, May 20, 2021 at 02:59:21AM +0200, Andrew Lunn wrote:
quoted
+static void mtk_gephy_config_init(struct phy_device *phydev) +{ + /* Disable EEE */ + phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0);Is EEE broken on this PHY? Or is this just to get it into a defined state?
As I said in commit message, the initialization (including EEE) is from the vendor driver. I have also tested it with EEE enabled by default on one of my APs, and got occasional link drops.
Otherwise
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew