Thread (14 messages) 14 messages, 4 authors, 2021-05-19

Re: [PATCH v1 2/2] ASoC: tegra: Unify ASoC machine drivers

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-05-18 20:12:02
Also in: alsa-devel, linux-tegra, lkml

18.05.2021 21:09, Rob Herring пишет:
quoted
+static const char * const tegra_active_low_hp_compats[] = {
+	"ad,tegra-audio-plutux",
+	"ad,tegra-audio-wm8903-medcom-wide",
+	"ad,tegra-audio-wm8903-tec",
+	"nvidia,tegra-audio-wm8903-cardhu",
+	"nvidia,tegra-audio-wm8903-harmony",
+	"nvidia,tegra-audio-wm8903-picasso",
+	"nvidia,tegra-audio-wm8903-seaboard",
+	"nvidia,tegra-audio-wm8903-ventana",
+	NULL,
I think this list should be added to the main match table below with 
data having a flag for active low HP. Then you only match once, don't 
need the exported function and the next difference is much easier to 
add.
Thank you for the suggestion. You're right that these compats will take
precedence.

I'm also now thinking that it should be okay to assume that the GPIO is
active-low by default. I haven't seen tegra boards with the active-high
configuration.

I'll remove the use of the exported function in v2.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help