Thread (12 messages) 12 messages, 4 authors, 2021-04-22

Re: [PATCH v4 4/4] pinctrl: add rsel setting on MT8195

From: Sean Wang <sean.wang@kernel.org>
Date: 2021-04-20 03:50:31
Also in: linux-arm-kernel, linux-gpio, linux-mediatek, lkml 

On Mon, Apr 12, 2021 at 10:57 PM Zhiyong Tao [off-list ref] wrote:

<snip>
quoted hunk ↗ jump to hunk
@@ -176,6 +180,12 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
                else
                        err = -ENOTSUPP;
                break;
+       case MTK_PIN_CONFIG_RSEL:
+               if (hw->soc->rsel_get)
+                       err = hw->soc->rsel_get(hw, desc, &ret);
+               else
+                       err = -EOPNOTSUPP;
I think that should want to be -ENOTSUPP to align other occurrences.
quoted hunk ↗ jump to hunk
+               break;
        default:
                err = -ENOTSUPP;
        }
@@ -295,6 +305,12 @@ static int mtk_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
                else
                        err = -ENOTSUPP;
                break;
+       case MTK_PIN_CONFIG_RSEL:
+               if (hw->soc->rsel_set)
+                       err = hw->soc->rsel_set(hw, desc, arg);
+               else
+                       err = -EOPNOTSUPP;
Ditto

+               break;
        default:
                err = -ENOTSUPP;
        }
--
2.18.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help