Re: [PATCH v4 4/9] ASoC: dt-bindings: wcd938x-sdw: add bindings for wcd938x-sdw
From: Rob Herring <robh@kernel.org>
Date: 2021-04-15 16:39:17
Also in:
alsa-devel, lkml
On Wed, Apr 14, 2021 at 04:48:40PM +0100, Srinivas Kandagatla wrote:
quoted hunk ↗ jump to hunk
Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC connected over SoundWire. This device has two SoundWire devices RX and TX respectively. This bindings is for those slave devices on WCD9380/WCD9385. Signed-off-by: Srinivas Kandagatla <redacted> --- .../bindings/sound/qcom,wcd938x-sdw.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd938x-sdw.yamldiff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x-sdw.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x-sdw.yaml new file mode 100644 index 000000000000..fff33c65491b --- /dev/null +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x-sdw.yaml@@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/qcom,wcd938x-sdw.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bindings for Qualcomm SoundWire Slave devices on WCD9380/WCD9385 + +maintainers: + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org> + +description: | + Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC. + It has RX and TX Soundwire slave devices. This bindings is for the + slave devices. + +properties: + compatible: + const: sdw20217010d00 + + reg: + maxItems: 1 + + qcom,direction: + description: direction of the SoundWire device instance + enum: + - rx + - tx
Was thinking these were some established bus properties... This would just be implied by the 'reg' property index. You could define 'reg-names' too I guess.
+ + qcom,port-mapping: + description: | + Specifies static port mapping between slave and master ports. + In the order of slave port index. + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 4 + maxItems: 5
qcom,rx-port-mapping and qcom,tx-port-mapping? Or keep a single property and the driver knows how many slave ports for each direction. IOW, an array of 9 with first 4 entries for tx and last 5 for rx.
+
+required:
+ - compatible
+ - reg
+ - qcom,direction
+ - qcom,port-mapping
+
+additionalProperties: false
+
+examples:
+ - |
+ soundwire@3230000 {
+ #address-cells = <2>;
+ #size-cells = <0>;
+ reg = <0x03230000 0x2000>;
+
+ codec@0,3 {
+ compatible = "sdw20217010d00";
+ reg = <0 3>;
+ qcom,direction = "tx";
+ qcom,port-mapping = <2 3 4 5>;
+ };
+ };
+
+...
--
2.21.0