Re: [PATCH v4 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
From: Rob Herring <robh@kernel.org>
Date: 2021-04-13 14:58:12
Also in:
linux-input, lkml
On Mon, Apr 12, 2021 at 07:30:19PM +0800, Ikjoon Jang wrote:
quoted hunk ↗ jump to hunk
This is for ChromeOS tablets which have a 'cros_cbas' switch device in the "Whiskers" base board. This device can be instantiated only by device tree on ARM platforms. ChromeOS EC doesn't provide a way to probe the device. Signed-off-by: Ikjoon Jang <redacted> --- Changes in v4: Define cros-cbase bindings inside google,cros-ec.yaml instead of a seperated binding document. .../devicetree/bindings/mfd/google,cros-ec.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml index 76bf16ee27ec..c76809cd9f7f 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml@@ -127,6 +127,18 @@ patternProperties: type: object $ref: "/schemas/extcon/extcon-usbc-cros-ec.yaml#" + "^cbas$":
Not a pattern, put under 'properties'.
+ type: object + properties: + compatible: + const: google,cros-cbas
Blank line
+ required: + - compatible
Blank line
+ additionalProperties: false + description:
Make this 1st or at least before 'properties'.
+ This device is used to signal when a detachable base is attached + to a Chrome OS tablet.
This can't happen at runtime?
quoted hunk ↗ jump to hunk
+ required: - compatible@@ -180,6 +192,10 @@ examples: interrupts = <99 0>; interrupt-parent = <&gpio7>; spi-max-frequency = <5000000>; + + base_detection: cbas { + compatible = "google,cros-cbas"; + }; }; };-- 2.31.1.295.g9ea45b61b8-goog