Thread (21 messages) 21 messages, 5 authors, 2021-04-20

Re: [v9,2/7] PCI: Export pci_pio_to_address() for module use

From: Lorenzo Pieralisi <hidden>
Date: 2021-04-13 09:53:32
Also in: linux-arm-kernel, linux-mediatek, linux-pci, lkml

On Wed, Mar 24, 2021 at 10:09:42AM +0100, Pali Rohár wrote:
On Wednesday 24 March 2021 11:05:05 Jianjun Wang wrote:
quoted
This interface will be used by PCI host drivers for PIO translation,
export it to support compiling those drivers as kernel modules.

Signed-off-by: Jianjun Wang <redacted>
---
 drivers/pci/pci.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 16a17215f633..12bba221c9f2 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4052,6 +4052,7 @@ phys_addr_t pci_pio_to_address(unsigned long pio)
 
 	return address;
 }
+EXPORT_SYMBOL(pci_pio_to_address);
Hello! I'm not sure if EXPORT_SYMBOL is correct because file has GPL-2.0
header. Should not be in this case used only EXPORT_SYMBOL_GPL? Maybe
other people would know what is correct?
I think this should be EXPORT_SYMBOL_GPL(), I can make this change
but this requires Bjorn's ACK to go upstream (Bjorn, it is my fault,
it was assigned to me on patchwork, now updated, please have a look).

Thanks,
Lorenzo
quoted
 
 unsigned long __weak pci_address_to_pio(phys_addr_t address)
 {
-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help