Thread (12 messages) 12 messages, 5 authors, 2021-04-03

Re: [PATCH v2 2/2] iio: temperature: add driver support for ti tmp117

From: Andy Shevchenko <hidden>
Date: 2021-04-03 13:53:18
Also in: linux-iio, lkml

On Fri, Apr 2, 2021 at 11:14 AM Lars-Peter Clausen [off-list ref] wrote:
On 4/1/21 11:36 AM, Andy Shevchenko wrote:
quoted
[...]
quoted
+       case IIO_CHAN_INFO_SCALE:
+               /* Conversion from 10s of uC to mC
+                * as IIO reports temperature in mC
+                */
+               *val = TMP117_RESOLUTION_10UC / 10000;
+               *val2 = (TMP117_RESOLUTION_10UC % 10000) * 100;
+               return IIO_VAL_INT_PLUS_MICRO;
You use 10000 many times, can you give it an appropriate name (via #define)?
#define TENTHOUSAND 10000 ;)
Actually, besides April fool's day, this can have a value if 1000 is
defined as mC _PER_uC or so.
Oh, wait. We have it already.

#define MILLIDEGREE_PER_DEGREE 1000





--
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help