Re: [PATCH v4 5/6] PCI: fu740: Add SiFive FU740 PCIe host controller driver
From: Krzysztof Wilczyński <hidden>
Date: 2021-04-01 06:36:37
Also in:
linux-clk, linux-pci, linux-riscv, lkml
Hi Greentime, [...]
+ /* Wait for wait_idle */ + ret = readl_poll_timeout(phy_cr_para_ack, val, val, 10, 5000); + if (ret) + dev_err(dev, "Wait for wait_ilde state failed!\n"); + + /* Clear */ + writel_relaxed(0, phy_cr_para_wr_en); + + /* Wait for ~wait_idle */ + ret = readl_poll_timeout(phy_cr_para_ack, val, !val, 10, 5000); + if (ret) + dev_err(dev, "Wait for !wait_ilde state failed!\n"); +}
[...]
+static int fu740_pcie_start_link(struct dw_pcie *pci)
+{
+ struct device *dev = pci->dev;
+
+ /* Start LTSSM. */
+ fu740_pcie_ltssm_enable(dev);
+ return 0;
+}The typos etc., are still here. See: https://lore.kernel.org/linux-pci/YFQqpojmJyX0l6lx@rocinante/ (local) Krzysztof