Re: [PATCHv1 1/6] dt-bindings: net: ethernet-phy: Fix the parsing of ethernet-phy compatible string
From: Anand Moon <hidden>
Date: 2021-03-25 17:39:12
Also in:
linux-amlogic, linux-arm-kernel, netdev
Hi Rob On Thu, 25 Mar 2021 at 22:26, Rob Herring [off-list ref] wrote:
On Thu, 25 Mar 2021 12:42:20 +0000, Anand Moon wrote:quoted
Fix the parsing of check of pattern ethernet-phy-ieee802.3 used by the device tree to initialize the mdio phy. As per the of_mdio below 2 are valid compatible string "ethernet-phy-ieee802.3-c22" "ethernet-phy-ieee802.3-c45" Cc: Rob Herring <robh@kernel.org> Signed-off-by: Anand Moon <redacted> --- Documentation/devicetree/bindings/net/ethernet-phy.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ethernet-phy.example.dt.yaml: ethernet-phy@0: compatible: 'oneOf' conditional failed, one must be fixed: ['ethernet-phy-id0141.0e90', 'ethernet-phy-ieee802.3-c45'] is too long Additional items are not allowed ('ethernet-phy-ieee802.3-c45' was unexpected) 'ethernet-phy-ieee802.3-c22' was expected 'ethernet-phy-ieee802.3-c45' was expected 'ethernet-phy-id0141.0e90' does not match '^ethernet-phy-ieee[0-9]{3}\\.[0-9][-][a-f0-9]{4}$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ethernet-phy.yaml See https://patchwork.ozlabs.org/patch/1458341 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Now I have a better understanding on device tree shema in Documentation/devicetree/bindings/net/ethernet-phy.yaml changes it meant to parse *ethernet-phy-id0181.4400* for example and not ethernet-phy-ieee802.3-c22 and ethernet-phy-ieee802.3-c45. So please dicard these changes. -Anand